Make Repo.create() use new RepoCreate class for settings by cvrebert · Pull Request #1095 · jcabi/jcabi-github

cvrebert · 2015-05-27T09:27:30Z

Fixes #1094 by adding a new parameter class (NewRepoSettings) and changing Repo.create() to accept an instance of this class as its argument rather than a raw JsonObject.

This requires updating a lot of test code since testcases create lots of temporary repos.

dmarkov · 2015-05-27T10:26:27Z

@cvrebert Let me find a reviewer for this pull request, thanks for submitting it

dmarkov · 2015-05-27T10:29:29Z

@pinaf please review, thanks

pinaf · 2015-05-27T23:39:23Z

@cvrebert I'd rather have it named RepoCreate. In the future other actions encoded in json could be RepoDelete, etc

pinaf · 2015-05-27T23:53:13Z

@cvrebert even though this PR is rather long, I really like what it does to the code :)

pinaf · 2015-05-27T23:53:18Z

@cvrebert 10 comments above.

cvrebert · 2015-05-28T00:23:37Z

@pinaf Responded to all your comments.

pinaf · 2015-05-28T01:32:43Z

@cvrebert thanks. 1 comment above.

cvrebert · 2015-05-28T01:35:22Z

@pinaf Done. Addressed that comment.

pinaf · 2015-05-28T01:47:04Z

@rultor merge
@cvrebert thank you

rultor · 2015-05-28T01:48:16Z

@rultor merge
@cvrebert thank you

@pinaf Thanks for your request. @yegor256 Please confirm this.

cvrebert · 2015-05-29T01:37:11Z

@yegor256 Please try merging? Hopefully this will have better luck than the other PR.

cvrebert · 2015-05-29T19:34:57Z

@yegor256 Please review+merge this.

yegor256 · 2015-05-29T20:02:58Z

@rultor try to merge again

rultor · 2015-05-29T20:03:10Z

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-05-29T20:08:46Z

@rultor try to merge again

@yegor256 Oops, I failed. You can see the full log here (spent 6min)

[INFO] [INFO] Finished at: 2015-05-29T20:07:59+00:00
[INFO] [INFO] Final Memory: 18M/276M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [WARNING] The requested profile "qulice" could not be activated because it does not exist.
[INFO] ..SUCCESS (7.1 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 2, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] 
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ jcabi-github ---
[INFO] Failsafe report directory: /home/r/repo/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:40 min
[INFO] Finished at: 2015-05-29T20:07:59+00:00
[INFO] Final Memory: 46M/462M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.failsafe.VerifyMojo.execute(VerifyMojo.java:194)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

pinaf · 2015-05-29T20:13:51Z

@rultor merge again

pinaf · 2015-05-29T20:14:14Z

@yegor256 github error 500 - unrelated

rultor · 2015-05-29T20:14:53Z

@rultor merge again

@pinaf Thanks for your request. @yegor256 Please confirm this.

cvrebert · 2015-05-29T22:16:25Z

@yegor256 Maybe we could use RetryWire for RtMilestonesITCase since GitHub seems to be flaky on it?

yegor256 · 2015-05-30T00:28:45Z

@cvrebert yes, good idea, can you do it in this branch?

GitHub seems to be frequently giving us HTTP 500 error responses in this testcase.

cvrebert · 2015-05-30T00:37:21Z

@yegor256 Done. Please retry merge.

cvrebert · 2015-05-31T18:37:18Z

@yegor256 Please merge.

pinaf · 2015-05-31T18:39:16Z

@rultor merge

rultor · 2015-05-31T18:39:51Z

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

yegor256 · 2015-06-01T19:24:23Z

@rultor merge

rultor · 2015-06-01T19:25:19Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-06-01T19:34:41Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

dmarkov · 2015-06-04T08:38:04Z

@pinaf 22 mins added to your account (payment number AP-81V683464X307641P), many thanks for your contribution! 141 hours and 2 mins spent here.. you're getting extra minutes here (c=7). +22 to your rating, your total score is +7744

dmarkov · 2015-06-04T08:40:03Z

@rultor deploy now pls

rultor · 2015-06-04T09:03:12Z

@rultor deploy now pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

rultor · 2015-06-04T09:12:47Z

@rultor deploy now pls

@dmarkov Done! FYI, the full log is here (took me 10min)

dmarkov · 2015-06-04T11:05:03Z

@cvrebert there is a puzzle in this code 1095-deaa3e41/#1108, we'll resolve it later

0pdd · 2022-07-05T19:44:02Z

@cvrebert the puzzle #unknown is still not solved.

dmarkov added CR labels May 27, 2015

dmarkov assigned pinaf May 27, 2015

dmarkov added the 15 mins label May 27, 2015

pinaf reviewed May 27, 2015
View reviewed changes

Make Repo.create() use RepoCreate class; fixes #1094

944cdc3

cvrebert changed the title ~~Make Repo.create() use NewRepoSettings class~~ Make Repo.create() use new RepoCreate class for settings May 28, 2015

cvrebert mentioned this pull request May 28, 2015

Temporary Repo creation code in tests is repetitive/verbose #1096

Closed

Use RetryWire in RtMilestonesITCase due to GitHub flakiness

8816c6c

GitHub seems to be frequently giving us HTTP 500 error responses in this testcase.

rultor merged commit 8816c6c into jcabi:master Jun 1, 2015

cvrebert deleted the friendlier-repo-create branch June 1, 2015 19:35

0pdd mentioned this pull request Sep 23, 2024

Repos.java:117-119: Add the ability to set the other... #1779

Open

Conversation

cvrebert commented May 27, 2015

Uh oh!

dmarkov commented May 27, 2015

Uh oh!

dmarkov commented May 27, 2015

Uh oh!

pinaf May 27, 2015

Choose a reason for hiding this comment

Uh oh!

cvrebert May 28, 2015

Choose a reason for hiding this comment

Uh oh!

pinaf commented May 27, 2015

Uh oh!

pinaf commented May 27, 2015

Uh oh!

cvrebert commented May 28, 2015

Uh oh!

pinaf commented May 28, 2015

Uh oh!

cvrebert commented May 28, 2015

Uh oh!

pinaf commented May 28, 2015

Uh oh!

rultor commented May 28, 2015

Uh oh!

cvrebert commented May 29, 2015

Uh oh!

cvrebert commented May 29, 2015

Uh oh!

yegor256 commented May 29, 2015

Uh oh!

rultor commented May 29, 2015

Uh oh!

rultor commented May 29, 2015

Uh oh!

pinaf commented May 29, 2015

Uh oh!

pinaf commented May 29, 2015

Uh oh!

rultor commented May 29, 2015

Uh oh!

cvrebert commented May 29, 2015

Uh oh!

yegor256 commented May 30, 2015

Uh oh!

cvrebert commented May 30, 2015

Uh oh!

cvrebert commented May 31, 2015

Uh oh!

pinaf commented May 31, 2015

Uh oh!

rultor commented May 31, 2015

Uh oh!

yegor256 commented Jun 1, 2015

Uh oh!

rultor commented Jun 1, 2015

Uh oh!

rultor commented Jun 1, 2015

Uh oh!

dmarkov commented Jun 4, 2015

Uh oh!

dmarkov commented Jun 4, 2015

Uh oh!

rultor commented Jun 4, 2015

Uh oh!

rultor commented Jun 4, 2015

Uh oh!

dmarkov commented Jun 4, 2015

Uh oh!

0pdd commented Jul 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!