Skip to content

module imports inside class methods #4

Description

@heilgeirr

not a good python practice.

example: JDI/web/selenium/elements/api_interact/get_element_module.py, GetElementModule.get_search_context.

Activity

  1. ZoiaOchikova commented on Mar 25, 2019

    @ZoiaOchikova
    Collaborator

    The better way is to restructure arhitecture for the following classes: GetElementModule, Element, BaseElement.
    The main problem is in GetElementModule.get_search_context method. Need to remove cyclic imports inside method. Remove non-OOP structures such as: isinstance(...), issubclass(...), type(element).

  2. self-assigned this
    on May 27, 2021
  3. linked a pull request that will close this issueModule imports inside class methods #62on Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions