Skip to content

Allow detecting repository on GitHub Enterprise#147

Merged
jekyllbot merged 1 commit into
jekyll:masterfrom
autotraderuk:master
Jan 2, 2019
Merged

Allow detecting repository on GitHub Enterprise#147
jekyllbot merged 1 commit into
jekyll:masterfrom
autotraderuk:master

Conversation

@mrmanc

@mrmanc mrmanc commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

Alters the regex that extracts the org/username and repo name from the repo address based on suggestion by @benbalter, so that it can cope with repos that do not exist on github.com (e.g. GitHub Enterprise).

Adds a test for this change.

Resolves #120

Alters the regex that extracts the org/username and repo name from the repo address, so that it can cope with repos that do not exist on github.com (e.g. GitHub Enterprise).

Adds a test for this change.
@ashmaroli ashmaroli changed the title Fix #120 by adapting the GitHub repo regex Allow detecting repository on GitHub Enterprise Dec 12, 2018
@ashmaroli ashmaroli requested a review from benbalter December 12, 2018 17:56
@mrmanc

mrmanc commented Dec 13, 2018

Copy link
Copy Markdown
Contributor Author

In addressing why I was getting local failures (#148) I found that the rspec expects looked wrong here, and have resolved this. I think I have also resolved #148. Would you be open to me adding those changes to this PR or would you prefer I open a new one? There’s a little overlap as I’ve copied the inaccurate expects convention in the commits for this PR already, and I’d like to tidy that up.

@parkr

parkr commented Jan 2, 2019

Copy link
Copy Markdown
Member

I believe the AppVeyor failure is a flake (a failed network connection, perhaps?).

Let's ship this as-is, and add further changes in a separate PR? Feel free to ping me directly, @mrmanc. Thank you!

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit e58d255 into jekyll:master Jan 2, 2019
jekyllbot added a commit that referenced this pull request Jan 2, 2019
@mrmanc

mrmanc commented Jan 3, 2019

Copy link
Copy Markdown
Contributor Author

Awesome, thanks for this. I’ll sort out a separate PR shortly. Apologies for pinging Ben—I thought it best as he’d suggested the fix. I’ll be sure to aim it at you next time :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repo detection does not work with github enterprise

4 participants