Add new attributes to return for users and repositories#158
Merged
benbalter merged 2 commits intoJan 29, 2019
Conversation
This commit: - Adds `hireable` to the whitelisted attributes available on the `owner` hash. - Adds decorator methods for `stargazers_count` and `forks_count` to the `Repository` object. Why? - This will allow users of this gem to access more useful information from users and repositories.
parkr
approved these changes
Jan 29, 2019
parkr
left a comment
parkr
left a comment
Member
There was a problem hiding this comment.
This looks great to me, thank you!!!
Member
|
@kenyonj Please adjust the changes so that tests pass locally at your end and on our CI. |
Member
|
@kenyonj I think you missed a test for checking the |
Contributor
Author
@ashmaroli |
Member
|
@ashmaroli I’ll make a PR for those user tests sometime tomorrow! |
Member
|
Thanks, @benbalter! I'm working on the tests now for |
Contributor
|
@parkr 🤘 If you tackle the tests, glad to help bump and release (if I remember how... 😄) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
hireableto the whitelisted attributes available on theownerhash.stargazers_countandforks_countto theRepositoryobject.Why?