Skip to content

Merge jenkins-35096_Altran_cppcheck_plugin_pipeline_support into master - #39

Closed
michael-doubez wants to merge 10 commits into
jenkinsci:masterfrom
michael-doubez:master
Closed

Merge jenkins-35096_Altran_cppcheck_plugin_pipeline_support into master#39
michael-doubez wants to merge 10 commits into
jenkinsci:masterfrom
michael-doubez:master

Conversation

@michael-doubez

Copy link
Copy Markdown
Contributor

Simple merge to get pipeline v2.

Bindings with configuration seem broken in freestyle job. It may already be the case in master.

@michael-doubez

Copy link
Copy Markdown
Contributor Author

The configuration part seems to be working fine.
It works in Freestyle jobs.

But I still get an error in Pipeline jobs. It may be related to my setup (I have strange errors about Jenkins version required being 2.32.2).

Can somebody try it ?

@michael-doubez

Copy link
Copy Markdown
Contributor Author

OK. Changing name to start with lowercase did the trick

@michael-doubez

Copy link
Copy Markdown
Contributor Author

@marcosteffan it is a working version

@michael-doubez

Copy link
Copy Markdown
Contributor Author

Given all the tries, you could do a squash/rebase rather than a plain merge.

@marcosteffan

Copy link
Copy Markdown
Contributor

IMHO this PR can be dropped since the functionality was already implemented in 22020cd

@michael-doubez

michael-doubez commented May 7, 2018

Copy link
Copy Markdown
Contributor Author

The duplication of config in CppcheckPublisher is wrong and this PR integrated cppcheckPublisher has a named pipeline (not a step).

It allowed me to write a step:

    cppcheckPublisher pattern: '**/result.xml'

instead of

    step([$class: 'CppcheckPublisher', ....])

@uhafner

uhafner commented May 21, 2018

Copy link
Copy Markdown
Member

BTW: Recently I added support for cppcheck in the warnings plug-in. Then you have full pipeline support out of the box. (And you automatically get all the other features of the warnings plug-in at no cost;-)

@kerrhome

kerrhome commented May 22, 2018 via email

Copy link
Copy Markdown

@uhafner

uhafner commented May 23, 2018

Copy link
Copy Markdown
Member

Well, if all issues have been resolved. This still requires some time, since this release contains a large number of changes. My plan is to get everything fixed by the end of July. I think that there will be some beta releases in June. (Snapshots are available for analysis-core and warnings, use at your own risk;-).

@kerrhome

kerrhome commented Jun 6, 2018

Copy link
Copy Markdown

We're going to try them out, Ullrich (warnings and analysis-core).

@michael-doubez

Copy link
Copy Markdown
Contributor Author

Closing pull request since it seems it won't be integrated

@uhafner

uhafner commented Sep 10, 2018

Copy link
Copy Markdown
Member

A beta version of the upcoming warnings plugin with cppcheck support is now available in the experimental update center. Requires Jenkins 2.81 LTS or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants