Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Custom commands can now opt into a keybinding hint in the panel footer, like built-in keybindings:
When
displayHintistrue, a hint labelled with the command'sdescription(falling back to the command itself) is shown in the footer of the panels where the command's context is active.The hint logic mirrors dispatch:
Notes:
displayHinton command menu entries. Only standalone commands that do not have a commandMenu may carry a hint.custom_commands/global_contextcovers both scopes, the shadowing case, and search suppression; config validation has unit tests for the new rejection.Please check if the PR fulfills these requirements
go generate ./...)Opening this for visibility per the contributing guide, happy for anyone to pull it into their fork.