Conversation
CHILD_MESSAGE_END is answered by the child exiting, not by a reply. Treating it like a finished call raced with shutdown and printed write EPIPE when workerIdleMemoryLimit was set.
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16474.
When
workerIdleMemoryLimitis set, Jest never runs in-band, so every run ends workers throughCHILD_MESSAGE_END. That message is answered by the child exiting, not by a reply, so_requestis still set when_onExitruns.If Node emits
exitbeforedisconnect,_child.connectedis still true and_onProcessEndcallscheckMemoryUsage(), which writes to a half-closed IPC channel:The same path restarts the worker when
idleMemoryLimitis0. Skip both the memory check and that restart when the pending request isCHILD_MESSAGE_END.Test plan
packages/jest-worker/src/workers/__tests__/ChildProcessWorker.test.tsthat force the race (connected === trueonexitafterCHILD_MESSAGE_END) for a normal idle limit and foridleMemoryLimit: 0.mainand pass with this change.yarn jest packages/jest-worker/src/workers/__tests__/ChildProcessWorker.test.ts packages/jest-worker/src/__tests__/process-integration.test.ts packages/jest-worker/src/workers/__tests__/WorkerEdgeCases.test.ts