Avoid null reference on cache read - #402
Merged
Merged
Conversation
Collaborator
|
Thanks, not sure how I convinced myself that was not the problem! |
bartelink
reviewed
Jul 3, 2023
bartelink
reviewed
Jul 3, 2023
Collaborator
|
@epNickColeman The expectation of any valid StreamToken is that the On reflection (OK, on eyeballing the code with sufficient sleep in the cold light of day), the technically correct and/or complete thing to do here is to have all The fault is hence with the caching logic - it's generating invalid Will adjust this in the context of #403 |
bartelink
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Handle nulls when unpacking Equinox.DynamoStore.Core.Token.isStale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle nulls when unpacking Equinox.DynamoStore.Core.Token.isStale