Skip to content

devbox shell gives no indication #25

Closed

Description

@bogosj

When I start a devbox shell I see no visual indication that I'm in the shell, but it definitely is working

image

# type lazygit
lazygit is hashed (/nix/store/alnmpxx1njfnv671sgnqxrws1bbari6r-lazygit-0.35/bin/lazygit)

# echo $PS1
\n\d \t\n\e[37;44m[\u@\h:\w]\[\e[00m\] \[\e[91m\]$(parse_git_branch)\[\e[00m\]\n#

# type parse_git_branch
parse_git_branch is a function
parse_git_branch ()
{
    git branch 2> /dev/null | sed -e '/^[^*]/d' -e 's/* \(.*\)/(\1)/'
}

Activity

  1. loreto commented on Aug 28, 2022

    @loreto
    Contributor

    @bogosj , may I ask what shell you use? What do you see if you run echo $SHELL? Is it bash?

  2. bogosj commented on Aug 28, 2022

    @bogosj
    Author

    Yes, bash.

  3. bogosj commented on Aug 28, 2022

    @bogosj
    Author

    I tried zsh, same situation:

    export SHELL=/usr/bin/zsh
    zsh
    bogosj@debian ~ % devbox shell
    Installing nix packages. This may take a while...
    Starting a devbox shell...
    bogosj@debian ~ % type lazygit
    lazygit is /nix/store/alnmpxx1njfnv671sgnqxrws1bbari6r-lazygit-0.35/bin/lazygit
    bogosj@debian ~ % exit
    bogosj@debian ~ % 
    
  4. loreto commented on Aug 28, 2022

    @loreto
    Contributor

    Yeah, we need to fix on our side. I just wanted to know which shell so I can make sure it works for it. I'll take a look this coming week.

  5. acrefoot commented on Aug 29, 2022

    @acrefoot

    Same issue with the prompt not being overridden on Mac :)

    acrefoot@MacBook ~ % echo $SHELL
    /bin/zsh
    acrefoot@MacBook ~ % devbox shell
    Installing nix packages. This may take a while...
    Starting a devbox shell...
    Restored session: Mon Aug 29 14:45:47 EDT 2022
    acrefoot@MacBook ~ % echo $shell
    /nix/store/7k3nqj8bpmpsk5vf8933hvs12q9307vc-bash-5.1-p16/bin/bash
    
  6. pinned this issue on Sep 1, 2022
  7. loreto commented on Sep 2, 2022

    @loreto
    Contributor

    @gcurtis merged a fix. It's going out on the next release. Closing.

  8. unpinned this issue on Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions