Repository navigation
[Rust Planner] part 2: devbox build - #104
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
| }, | ||
| "start_stage": { | ||
| "command": "", | ||
| "command": "rustup default stable \u0026\u0026 cargo run \u0026\u0026 rustc --version", |
There was a problem hiding this comment.
Why do we need \u0026. Is that what the go json marshaller does? Can we make it output & instead?
There was a problem hiding this comment.
its from json marshaller. I'll see if there's a way to avoid it...
a4e9602 to
0bdf570
Compare
d56ee29 to
70845cd
Compare
21a4714 to
e72f016
Compare
|
@loreto I added the most minimal As I look into That said, I can see other planners wanting a runtime-overlay. Do we want to distinguish dev-overlays and runtime-ovarlays in the code now? If so, there are a couple of options on implementing it:
WDYT? For now, I'm going to punt on this question (of dev versus runtime overlays) and consider Overlays as just DevOverlays, but wanted to raise it in case folks feel we should add it up-front. |
loreto
left a comment
There was a problem hiding this comment.
LGTM
I would rename Overlays to NixOverlays. I don't think we need to distinguish between Dev and Runtime overlays for the time being.
72376a4 to
141afe1
Compare
LucilleH
left a comment
There was a problem hiding this comment.
Try rebasing and run go test ./... again
| RuntimePackages: []string{"gcc"}, | ||
| SharedPlan: plansdk.SharedPlan{ | ||
| BuildStage: &plansdk.Stage{ | ||
| Command: "cargo build --release", |
There was a problem hiding this comment.
@savil when you rebase, I removed the default install stage inputFiles field, so you'd have to add
InstallStage: {
InputFiles: []string{"."}
}
| BuildStage: &plansdk.Stage{ | ||
| Command: "cargo build --release", | ||
| }, | ||
| StartStage: &plansdk.Stage{ |
There was a problem hiding this comment.
Similarly, add InputFiles for StartStage
985ca9d to
1b2044f
Compare
a893c9f to
fabfbb8
Compare
2f744d1 to
201c02c
Compare
fabfbb8 to
9fea010
Compare
|
image size:
The current implementation is (1). I want to explore alternate implementations to reduce the size. |
9fea010 to
9c53afd
Compare
|
With that big of a difference, I would say forget the suggestion of checking the version within the testdata example, and let's just generate the small images. |
9c53afd to
331ee31
Compare
|
Updated to just have |
331ee31 to
dfe06ac
Compare

Summary
This PR adds support for
devbox buildfor Rust projects.gccnix-package because Rust needs it forlibccalls.cargo build --release, instead ofcargo runto avoid needing to add thecargonix package in the final runtime image.How was it tested?
plan.jsonfiles totestdata.testdata/rustdirectory, did:devbox builddocker run devbox-> inspected output to ensure correct rust version was executed with.