Repository navigation
Conversation
github-actions
Bot
added
the
vouch:trusted
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
jhomra21
force-pushed
the
fix/resumed-subagent-thread
branch
from
October 18, 2026 14:47
67946f3 to
0481157
Compare
Thread transfer impact
This comment will update automatically after the next completed run. |
jhomra21
marked this pull request as draft
October 30, 2026 02:32
…med-subagent-thread
jhomra21
changed the title
jhomra21
changed the title
jhomra21
changed the title
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a server restart, a resumed subagent can send events for its child thread before the current run has seen that child created.
routeProviderEventdrops those events, because the child thread isn't in the run's owned threads and the adoption path requires a workflow. The child thread stops updating.Change
routeProviderEventinRunExecutionService.tsnow adopts a coordinator's child thread whenever the coordinator belongs to the run, with or without a workflow. Workflow members still map to the coordinator's child. Unowned coordinators and null child IDs are still not adopted.Scope and approval
This is a small fix for an obvious routing bug, in
RunExecutionService.tsand its test. Open issue pingdotgg#15567 has a similar symptom but a different cause (lost Codex adapter registrations after a restart), so I haven't linked it as fixed.Verification
claims a resumed run-owned subagent thread before routing its child eventsfails on upstream maincba30591f9, at the assertion that the child thread is owned. Current mainc8a606c7b7keeps the same workflow-only guard.vp env exec --node 26.12.1 -- vp test run apps/server/src/orchestration-v2/RunExecutionService.test.ts: 55 passed.vp env exec --node 26.12.1 -- vp run check:changed: format, lint, knip, GraphQL and typecheck passed. Its tests had 10 failures in upstream'sbootService,serviceProtection,agentScopeandServerBrowserContextstests, which expect Linux paths and services. They fail on this Windows machine without this change.Built with Claude Opus 5.5 through Factory Droid in T3 Code. Upstream preparation by GPT-6 Luna, orchestrated by Claude Opus 5.5, through Factory Droid in T3 Code.