chore(tui): clear two CodeQL quality alerts in TextInputDialog - #12
Merged
Merged
Conversation
Add the missing constructor <summary> (cs/xmldoc/missing-summary) and extract the newline-chord test into a private IsNewlineChord predicate (cs/complex-condition). No behaviour change.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+195
to
+196
| (baseCode == KeyCode.Enter && (key.IsCtrl || key.IsShift)) || | ||
| (baseCode == KeyCode.J && key.IsCtrl); |
jinyeow
added a commit
that referenced
this pull request
Jul 18, 2026
* origin/main: chore(tui): clear two CodeQL quality alerts in TextInputDialog (#12) perf(pr): make PR review feel local — and fix four wrong-file bugs found on the way (#11) feat(tui): lazygit-style shell chrome — context keybar, showcmd, real tab strips (#27) # Conflicts: # CHANGELOG.md # docs/adr/0008-client-side-diff-and-line-comments.md # src/Cobalt.Tui/App/CobaltShell.cs # src/Cobalt.Tui/App/CobaltTuiApp.cs # src/Cobalt.Tui/Screens/DiffListDataSource.cs # src/Cobalt.Tui/Screens/DiffReviewDialog.cs # src/Cobalt.Tui/ViewModels/PrDiffViewModel.cs # src/Cobalt.Tui/ViewModels/PrListViewModel.cs # tests/Cobalt.Core.Tests/Text/IntraLineDiffTests.cs # tests/Cobalt.Tui.Tests/Input/KeymapRouterTests.cs # tests/Cobalt.Tui.Tests/Screens/DiffListDataSourceTests.cs
jinyeow
added a commit
that referenced
this pull request
Jul 18, 2026
* origin/main: perf(round-2): diff-render, transport & input hot-path optimizations (#18) chore(tui): clear two CodeQL quality alerts in TextInputDialog (#12) perf(pr): make PR review feel local — and fix four wrong-file bugs found on the way (#11) feat(tui): lazygit-style shell chrome — context keybar, showcmd, real tab strips (#27) perf(tui): cut redundant redraws and diff re-tokenization (#9) docs: add CLAUDE.md project guidance for Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two actionable CodeQL quality alerts standing on
mainin the in-TUI text-input code (from #7). The other four open alerts were dismissed as false positives / intentional (crash-boundary catches per ADR 0013, a cast needed for overload resolution, an if/else clearer than a ternary).Changes
cs/xmldoc/missing-summary(#193) — added the missing<summary>to theTextInputDialogconstructor; its<param>docs were already present.cs/complex-condition(#198) — extracted the newline-chord test into a privateIsNewlineChord(key, baseCode)predicate, keeping the driver-quirk rationale on its doc comment.No behaviour change. These files are untouched by #11 (PR-view performance), so they're split out as separate repo hygiene.
Verify
dotnet test --filter "FullyQualifiedName~TextInputDialog|FullyQualifiedName~DetailDialogKeyDelivery"→ 48 passing