[ISSUE - 1167] Add support for child-first resolution#1171
Closed
sshailabh wants to merge 1 commit into
Closed
Conversation
|
@sshailabh That's awesome! Can't wait for it to be merged 🔥 |
|
@jknack Would you please take a look at this PR? |
Owner
|
This is the default behaviour no need to add anything, you can see the test here: https://github.com/jknack/handlebars.java/blob/master/handlebars/src/test/java/com/github/jknack/handlebars/i1167/Issue1167.java |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handlebars.js uses child-first resolution instead of parent-first resolution: https://handlebarsjs.com/guide/expressions.html#changing-the-context
This pr allows to define the resolution(
child-firstvsparent-first) in the Handlebars intilaization allowing clients to decide the resolution method. Default resolution is parent-first making it backward compatible.Issue link: #1167