Skip to content

chore: remove unneeded special case - #54

Merged
cawalch merged 2 commits into
jmespath-community:mainfrom
SamMousa:chore-remove-shortcut
May 24, 2025
Merged

cawalch merged 2 commits into
jmespath-community:mainfrom
SamMousa:chore-remove-shortcut

Conversation

@SamMousa

@SamMousa SamMousa commented May 21, 2025 •

Copy link
Copy Markdown
Contributor

While working on the PHP implementation I noticed some unneeded code paths in the typescript implementation.

@springcomp
springcomp requested a review from cawalch May 21, 2025 15:13
@springcomp

springcomp commented May 21, 2025 •

Copy link
Copy Markdown
Contributor

@SamMousa thank you for your contribution.

That is interesting. It seems to be path of code that will never trigger.
It seems we have the same code in both the Python and the Golang ports.

Other than that, it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants