json schema validation is fails on empty graph #53

Activity

1. schaumb

   changed the title [-]json schema fails on empty graph[/-] [+]json schema validation is fails on empty graph[/+] on Mar 23, 2021
2. wshayes commented on Mar 23, 2021

   

   wshayes

   on Mar 23, 2021

   Member

   More actions

   Not sure I'm following - it should fail on an empty graph object as there are required properties in the graph object.

   Are you saying it should not fail? or that we have a test that is passing that should fail?
3. schaumb commented on Mar 23, 2021

   

   schaumb

   on Mar 23, 2021

   Author

   More actions

   Schema:
   https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json

   Graph:

   Examples

   Additional examples
   empty single graph

   {
     "graph": {}
   }
   

   The documentation says this is the empty graph representation.
   The schema is failing on this graph, because oneOf matches on multiple subschema (see: img).

   This empty graph is not tested in the test directory.
4. wshayes commented on Mar 23, 2021

   

   wshayes

   on Mar 23, 2021 via email

   Member

   More actions

   Ah - thanks - I’ll need to update the documentation.

   …

   On Mar 23, 2021, at 10:03 AM, Bela Schaum ***@***.***> wrote: Schema: https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json <https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json> Graph: Examples Additional examples empty single graph { "graph": {} } The documentation says this is the empty graph representation. The schema is failing on this graph, because oneOf matches on multiple subschema (see: img). This empty graph is not tested in the test directory. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACZF53ZNRPMVPR7I4BPP7TTFCNSNANCNFSM4ZT565JA>.