JUL-159: Keep rejected LLVM declarations atomic - #454
Draft
julia-script wants to merge 2 commits into
Draft
julia-script wants to merge 2 commits into
julia-script wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidStateerrors, successful same-name retries, compatible occupied-function reuse, and preserved strip-mode behaviorWhy this matters
A handled foreign-owner rejection previously left an orphan global, handle, attachment slot, and reserved name without a function or variable actor. The rejected call poisoned the reusable builder and made a valid same-name retry fail.
Before
After
The compatible occupied-function fast path remains ahead of prefix/prologue validation.
strip: truestill ignores debug expressions.Tracking
@silklang/llvmcorrection with no Silk language or standard-library contract change518513e78b276e4fa4bd2a808caed6ad747ae047Verification
Global.test.tsfailed with the expected orphan global/handle/attachment diffpnpm --filter @silklang/llvm exec vitest run test/Global.test.ts— 6 tests passed (469 ms final local run)pnpm --filter @silklang/llvm typecheck— passedgit diff --check— passedRisk and deferred work
Risk is limited to declaration validation order and fuller internal snapshots. General BuilderState rollback, function compatibility changes, adjacent already-safe declaration actors, and JUL-158 performance work remain out of scope.