Repository navigation
Conversation
pingdotgg#4036 pr3910-thread-feed-layout added a full-screen "Loading messages" placeholder over the feed while a thread hydrates, with a spinner and the detail line "Catching up this thread before showing the conversation." It arrived as part of the layout work rather than as a deliberate design change, and it reads as an awkward interstitial on a transition that is usually instant. Removes the overlay, the ThreadFeedPlaceholder `loading` prop it was the only caller of, and the spinner that prop gated. ActivityIndicator keeps its other two uses in this file. Deliberately keeps `listMountState`, which lands in the same PR but is a distinct hydration fix: it reserves the filled list identity so detail arrival does not replace the native list mid-transition, and the layout effect below it re-reports the composer content inset either way. That is correct whether or not the overlay draws.
github-actions
Bot
added
vouch:unvouched
mwolson
marked this pull request as ready for review
July 28, 2026 03:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the full-screen "Loading messages" overlay this branch adds over the
thread feed while a thread hydrates. Everything else in the layout and Markdown
work is untouched.
Opening this against
codex/pr3910-thread-feed-layoutrather thanmainbecause the overlay only exists on this branch. It is a single commit on your
current head, so it should merge or cherry-pick cleanly whichever way you prefer
to take it.
Problem and Fix
StyleSheet.absoluteFillplaceholder titled "Loading messages" covers the feed whenevercontentPresentation.kind === "loading". The UI wasn't intended to be released and ended up adding an extra spinner to the page.ThreadFeedPlaceholderloadingprop it was the only caller of, and theActivityIndicatorthat prop gated.Deliberately not reverted
listMountStatelands in the same commit and looks loading-related, but it is aseparate hydration fix: it reserves the filled list identity so detail arrival
does not replace the native list mid-transition, and the layout effect below it
re-reports the composer content inset regardless of whether the overlay draws.
Reverting it would reintroduce the remount that its comment describes, so it
stays.
Validation
vp checkand the mobile package typecheck are clean, andapps/mobiletestspass (95 files, 574 tests). Exercised on a signed Release build installed on a
physical iPhone.