Include full display name in legacy XML reports - #5524
Merged
Merged
Conversation
Rather than just including the display name of the test, the display names of all ancestors are now included as well, separated by the `>` character. This includes display names of parents otherwise not represented in the legacy XML format (for example, the invocation of a `@ParameterizedClass`). Resolves #5409.
github-actions
Bot
added
backport-candidate
component: Platform
theme: reporting
type: bug
labels
✅ All tests passed ✅🏷️ Commit: ea0a53f Learn more about TestLens at testlens.app. |
jbduncan
reviewed
Mar 17, 2026
jbduncan
left a comment
jbduncan
left a comment
Contributor
There was a problem hiding this comment.
Hi @marcphilipp - just a super minor nit, but otherwise this PR looks fantastic to me. Good work! 👍
| try (XmlReport report = new XmlReport(out)) { | ||
| report.write(testIdentifier, tests); | ||
| try (var report = new XmlReport(out)) { | ||
| report.write(testIdentifier, tests, this.reportData.getTestPlan()); |
Contributor
There was a problem hiding this comment.
I've had a look at XmlReport and it looks like it uses reportData.getTestPlan() directly in a few places.
Have you considered either:
- Inlining this parameter, or
- Replacing all uses of
reportData.getTestPlan()with this parameter?
Member
Author
There was a problem hiding this comment.
Thanks for the review! I went with option 1. Done in f710172
Contributor
There was a problem hiding this comment.
Brilliant, I'm happy with that. Thanks for making the fix so quickly! 👍
6 tasks done
amilbourne
added a commit
to amilbourne/junit-framework
that referenced
this pull request
Apr 21, 2026
Rather than just including the display name of the test, the display names of all ancestors are now included as well, separated by the `>` character. This includes display names of parents otherwise not represented in the legacy XML format (for example, the invocation of a `@ParameterizedClass`). This is a backport of commit ee3a100 Changes were made to compile under Java 8 Co-authored-by: Marc Philipp <mail@marcphilipp.de> Signed-off-by: Anthony Milbourne <18662115+amilbourne@users.noreply.github.com>
marcphilipp
added a commit
that referenced
this pull request
Apr 25, 2026
Rather than just including the display name of the test, the display names of all ancestors are now included as well, separated by the `>` character. This includes display names of parents otherwise not represented in the legacy XML format (for example, the invocation of a `@ParameterizedClass`). This is a backport of commit ee3a100 Changes were made to compile under Java 8 Co-authored-by: Marc Philipp <mail@marcphilipp.de> Signed-off-by: Anthony Milbourne <18662115+amilbourne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than just including the display name of the test, the display
names of all ancestors are now included as well, separated by the
>character. This includes display names of parents otherwise not
represented in the legacy XML format (for example, the invocation of a
@ParameterizedClass).Resolves #5409.