Repository navigation
Centralize excluded routers in shared EXCLUDED_ROUTERS constant (fixes #49) - #89
Open
GentechLabs wants to merge 1 commit into
Open
GentechLabs wants to merge 1 commit into
GentechLabs wants to merge 1 commit into
Conversation
…jup-ag#49) The integration test suites carried six hardcoded excludeRouters strings with drift between them ('metis' vs 'metis,hashflow,dflow,pyth,okx'). As Jupiter adds routers, these rot and quotes under test can be won by an excluded router. All six sites now reference one shared constant in tests/params.ts so future router additions are a one-line change. Test-only change: no program, SDK, or server code touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The integration test suites carry six hardcoded
excludeRoutersstrings with drift between them ("metis"vs"metis,hashflow,dflow,pyth,okx"). As Jupiter adds routers, these lists rot and a quote under test can be won by a router that should have been excluded — the exact problem in #49.This PR centralizes the exclusion list as a single shared constant
EXCLUDED_ROUTERSintests/params.tsand points all six call sites at it. Future router additions become a one-line change in one file, and the drift between suites disappears.Closes #49 (alongside the acceptance-test exclusions added in #59).
Audit Status
If Required
If Not Required (Justification)
Test-only change: modifies
tests/params.ts,tests/suites/integration/quote.ts, andtests/suites/integration/swap.ts— no program, SDK, server-example, or webhook-api code is touched. No on-chain logic, no executable shipped to production, no state machine or settlement path altered. Risk is limited to test configuration values; behavior of the order-engine and webhook server is unchanged.Deployment Intent