Skip to content

Centralize excluded routers in shared EXCLUDED_ROUTERS constant (fixes #49) - #89

Open
GentechLabs wants to merge 1 commit into
jup-ag:mainfrom
GentechLabs:fix/excluded-routes-centralize
Open

GentechLabs wants to merge 1 commit into
jup-ag:mainfrom
GentechLabs:fix/excluded-routes-centralize

Conversation

@GentechLabs

Copy link
Copy Markdown

Summary

The integration test suites carry six hardcoded excludeRouters strings with drift between them ("metis" vs "metis,hashflow,dflow,pyth,okx"). As Jupiter adds routers, these lists rot and a quote under test can be won by a router that should have been excluded — the exact problem in #49.

This PR centralizes the exclusion list as a single shared constant EXCLUDED_ROUTERS in tests/params.ts and points all six call sites at it. Future router additions become a one-line change in one file, and the drift between suites disappears.

Closes #49 (alongside the acceptance-test exclusions added in #59).

Audit Status

  • Required — Audit completed and artifacts attached
  • Not Required — Justification below (3–5 lines)

If Required

  • Audit report link: N/A
  • Scope: N/A
  • Key findings + fixes: N/A

If Not Required (Justification)

Test-only change: modifies tests/params.ts, tests/suites/integration/quote.ts, and tests/suites/integration/swap.ts — no program, SDK, server-example, or webhook-api code is touched. No on-chain logic, no executable shipped to production, no state machine or settlement path altered. Risk is limited to test configuration values; behavior of the order-engine and webhook server is unchanged.

Deployment Intent

  • No deploy
  • Deploy new program
  • Upgrade existing program

…jup-ag#49)

The integration test suites carried six hardcoded excludeRouters strings
with drift between them ('metis' vs 'metis,hashflow,dflow,pyth,okx').
As Jupiter adds routers, these rot and quotes under test can be won by
an excluded router. All six sites now reference one shared constant in
tests/params.ts so future router additions are a one-line change.

Test-only change: no program, SDK, or server code touched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend list of excluded routes

1 participant