Skip to content

Add new constructor for Histogram and Summary taking rvalue ref of parameters - #563

Merged
gjasny merged 1 commit into
jupp0r:masterfrom
sjanel:chore/addmoveconstructor_histogram_summary
Apr 3, 2022
Merged

Add new constructor for Histogram and Summary taking rvalue ref of parameters#563
gjasny merged 1 commit into
jupp0r:masterfrom
sjanel:chore/addmoveconstructor_histogram_summary

Conversation

@sjanel

@sjanel sjanel commented Mar 28, 2022

Copy link
Copy Markdown
Contributor
  • Set default values to object fields in header file to limit code duplication as well.
  • Mark constructors taking only one parameter as explicit

@sjanel
sjanel force-pushed the chore/addmoveconstructor_histogram_summary branch 3 times, most recently from 8e69ef1 to 6b8f225 Compare April 2, 2022 11:31
Comment thread core/src/summary.cc
Comment thread core/src/summary.cc
Comment thread core/include/prometheus/histogram.h Outdated
Comment thread core/src/summary.cc Outdated
@sjanel
sjanel force-pushed the chore/addmoveconstructor_histogram_summary branch 2 times, most recently from ae8bbe7 to 56b37e8 Compare April 3, 2022 15:52
@sjanel
sjanel force-pushed the chore/addmoveconstructor_histogram_summary branch from 56b37e8 to 450718f Compare April 3, 2022 15:54
@gjasny
gjasny merged commit d81fd3b into jupp0r:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants