Repository navigation
test(inspector): stop gating body spill on process working set - #1088
Merged
Merged
Conversation
The 7.0.21 promote ran the same tree as the published beta and failed Ubuntu ui-portable at +273MB RSS after the in-memory body counter had passed. Linux VmRSS is not returned after GC.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 7.0.21 promote failed
ui-portable (ubuntu-latest)on the same tree as the published beta.LiveCapture_LargeResponses_WorkingSetStableAfterSpillreported working-set growth of 273 MB (158 to 432). The in-memory body counter, which is checked first, had already passed.betaat462089aband the published betad6eed64ehave the same files. Both jobs used ubuntu-24.04 image20261004.327and libmsquic 2.6.2. LinuxEnvironment.WorkingSetis VmRSS, and the runtime does not return those pages after GC. The test now assertsInMemoryBodyBytesonly.Test plan
TestCategory=Inspector-Stresspassed locally (5 tests)ui-portableon the promote pull request