Repository navigation
Fix packaged control panel version - #389
Open
Aghayenoor wants to merge 1 commit into
Open
Aghayenoor wants to merge 1 commit into
Aghayenoor wants to merge 1 commit into
Conversation
Use the server version when building the web client and invalidate the web build cache when the server version changes. Add a container regression check for release and prerelease versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings panel reads the frontend package version, which remains 1.3.0 independently of the server release. Fixes #368.
During the packaged web build, read the version from XVNCVERSION in xvnc.c and set it in the container's copy of the frontend package.json before Vite builds the Settings asset. Rebuild cached web output when that source changes. The frontend submodule and its tracked package metadata are unchanged.
Validation:
A full Xvnc build, desktop/browser session, distro package installation, and private functional test suite were not run. The regression test stubs npm to test version propagation; the separate production build exercises the real Vite build.