Skip to content

Fix packaged control panel version - #389

Open
Aghayenoor wants to merge 1 commit into
kasmtech:masterfrom
Aghayenoor:bugfix/VNC-368_control_panel_version
Open

Aghayenoor wants to merge 1 commit into
kasmtech:masterfrom
Aghayenoor:bugfix/VNC-368_control_panel_version

Conversation

@Aghayenoor

@Aghayenoor Aghayenoor commented Nov 4, 2026 •

Copy link
Copy Markdown

The Settings panel reads the frontend package version, which remains 1.3.0 independently of the server release. Fixes #368.

During the packaged web build, read the version from XVNCVERSION in xvnc.c and set it in the container's copy of the frontend package.json before Vite builds the Settings asset. Rebuild cached web output when that source changes. The frontend submodule and its tracked package metadata are unchanged.

Validation:

  • Container regression test passes for 1.5.2 and 1.6.0~beta and rejects a missing version definition. Against the original build script it fails with 1.3.0 != 1.5.2.
  • Built builder/dockerfile.www.build with OUTPUT_OWNER_UID=1000 and ran its web-build entrypoint with networking disabled. The production build passed; the shipped package.json and generated control-panel asset contain 1.5.1, matching the current server source.
  • Shell syntax and diff whitespace checks passed in containers.

A full Xvnc build, desktop/browser session, distro package installation, and private functional test suite were not run. The regression test stubs npm to test version propagation; the separate production build exercises the real Vite build.

Use the server version when building the web client and invalidate the web build cache when the server version changes. Add a container regression check for release and prerelease versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version number in Control Panel's Setting menu

1 participant