[Sarthak-Shreshtha01]

Summary

A LogicalClusterMigration could be deleted while the migration was still running. The origin shard now adds a finalizer before the migration starts. The destination shard removes it when the migration is completed, and any involved shard removes it when the migration has failed, so failed migrations do not get stuck.

Added tests: TestAddFinalizer and TestReconcile_removesFinalizerInTerminalPhases.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #4405

Release Notes

LogicalClusterMigration objects now get a finalizer that prevents their deletion while the migration is in progress.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[kcp-ci-bot]

Hi @Sarthak-Shreshtha01. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ntnn]

/ok-to-test

Thank you! This looks very good already

[ntnn]

/test pull-kcp-test-e2e-sharded

Unrelated:

=== FAIL: test/e2e/garbagecollector TestCrossNamespaceReferences (35.23

[ntnn]

/lgtm
/approve

Thank you!

[kcp-ci-bot]

LGTM label has been added.

Details

Git tree hash: 1171d7c673e6d9be26cafb6b97e61364b8913edf

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ntnn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment