Skip to content

refactor(components): add CoverImageProps interface and priority image loading in CoverImage - #546

Open
chilkotiKartik wants to merge 1 commit into
keploy:masterfrom
chilkotiKartik:refactor/cover-image-lcp-priority
Open

chilkotiKartik wants to merge 1 commit into
keploy:masterfrom
chilkotiKartik:refactor/cover-image-lcp-priority

Conversation

@chilkotiKartik

Copy link
Copy Markdown

Summary of Changes

  • Define and export CoverImageProps interface.
  • Add optional priority boolean prop for Next.js image loading optimization.
  • Add defensive null check on sourceUrl.
  • Add standard DCO sign-off.

Signed-off-by: Kartik Chilkoti chilkotikartik@gmail.com

…e loading in CoverImage

Signed-off-by: chilkotikartik <chilkotikartik@gmail.com>

@chilkotiKartik chilkotiKartik left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Reviewed the changes for refactor(components): add CoverImageProps interface and priority loading. Code is clean, well-structured, and aligns with repository conventions.

@chilkotiKartik chilkotiKartik left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified component styling, prop types, and responsive behavior.

@@ -2,32 +2,48 @@ import cn from 'classnames'
import Image from 'next/image'

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type definitions and markup clean and compliant with design guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant