Research :: Readiness Scheduling Gates #1223

Activity

1. thisthat

   added

   enhancementNew feature or requestNew feature or request

   questionFurther information is requestedFurther information is requested

   scheduler

   on Apr 13, 2023
2. thisthat

   added this to the 0.8 milestone on Apr 13, 2023
3. thisthat

   added this to 🛣️ Keptn Roadmapand Keptn Lifecycle Toolkiton Apr 13, 2023
4. github-project-automation

   moved this to Backlog in 🛣️ Keptn Roadmapon Apr 13, 2023
5. thisthat

   moved this from Backlog to In Progress in 🛣️ Keptn Roadmapon Apr 13, 2023
6. thisthat

   moved this to 🏗 Shaping in Keptn Lifecycle Toolkiton Apr 13, 2023
7. thisthat commented on Apr 13, 2023

   

   thisthat

   on Apr 13, 2023

   Last edited by thisthat

   MemberAuthor

   More actions

   Old PoC that used a workaround with extra labels: #632
8. RealAnna

   self-assigned this

   on Apr 13, 2023
9. RealAnna

   moved this from 🏗 Shaping to 🏃 In progress in Keptn Lifecycle Toolkiton Apr 19, 2023
10. thisthat

    modified the milestones: 0.7.1, 0.8 on May 3, 2023
11. thisthat commented on May 4, 2023

    

    thisthat

    on May 4, 2023

    MemberAuthor

    More actions

    PR kubernetes-sigs/controller-runtime#2189 has been merged and unlocks this research
12. RealAnna commented on May 22, 2023

    

    RealAnna

    on May 22, 2023

    Last edited by RealAnna

    Contributor

    More actions

    The new controller runtime v 0.15.0 will introduce multiple breaking changes that will require code refactoring/changes in all our operators:

    • the server struct for the webhooks is now an interface, so we need to change all reference of it since we use it to override configs when setting up certificates
    • the decoder injector has been removed this means we need to explicitly pass one to the webhooks, as written in Remove Decoder Injector interface from webhook #1445
    • few ways to setup the controller manager are deprecated: to set up the port we should use WebhookServer.Port instead and for ClientDisableCacheFor weshould use Client.Cache.DisableCacheFor.
    • multiple controller unit tests still fail in the poc after the new library version, so they need refactoring. Maybe I missed even other breaking changes 😿

    After these changes and the import of controller runtime and k8s 1.27.1 libraries, we can substitute the scheduler with gates, in the poc this is done by adding an extra webhook reacting to the creation of new pods:

    • extract common functions from the mutating webhook
    • introduce a gating webhook that simply adds a keptn gated at creation
    • remove the gate in the webhook instance controller after all pre check passed
    • modify operator/config/default/webhooknamespaces_patch.yaml and operator/config/webhook/manifests.yaml to include the new webhook
    • add the extra webhook in the list passed to builder.run in operator/main.go
    • create new test and adapt existing ones, this is partially done in the poc poc: scheduling gates beta verison #1249

    It is left do decide also what to do with the scheduler. Shall we do a breaking change and delete it or add some logic to enable/disable gates or scheduler for at least one version?
13. RealAnna

    closed this as completedon May 22, 2023
14. github-project-automation

    moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkiton May 22, 2023
15. github-project-automation

    moved this from In Progress to Done in 🛣️ Keptn Roadmapon May 22, 2023