docker: initialise the rpm database in the container image - #3180
Merged
Conversation
The rpm database that tuxmake's *rpm-pkg targets need was created by
'rpmdb --initdb' at the start of every build. It does not change
between builds, so create it once in the kernelci docker fragment
instead.
/var/lib/rpm is not writable by the build user, so the database lives
under the kernelci home directory and ~/.rpmmacros points _dbpath at
it via %{getenv:HOME}. _topdir stays in the per-build workspace, since
rpmbuild output is collected from there into the artifacts directory.
The initdb is tolerant of rpm being missing, as images built from
base/python.jinja2 do not install it.
Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Contributor
|
Yes that was what I meant with my comment in #3178 |
Member
Author
|
Thanks @roxell (I split the pr's out on purpose) |
Member
|
https://staging.kernelci.org:9000/viewer?node_id=6a76069a37081d53fb49cfbd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rpm database that tuxmake's *rpm-pkg targets need was created by 'rpmdb --initdb' at the start of every build. It does not change between builds, so create it once in the kernelci docker fragment instead.
/var/lib/rpm is not writable by the build user, so the database lives under the kernelci home directory and ~/.rpmmacros points _dbpath at it via %{getenv:HOME}. _topdir stays in the per-build workspace, since rpmbuild output is collected from there into the artifacts directory.
The initdb is tolerant of rpm being missing, as images built from base/python.jinja2 do not install it.