This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
build.jpl: Improve reliability of build process - #109
Merged
Merged
Conversation
nuclearcat
force-pushed
the
IMPROVE-reliability-patches
branch
7 times, most recently
from
October 3, 2022 10:49
e6f1451 to
642d9a6
Compare
mgalka
reviewed
Oct 10, 2022
| sh(script: "az aks list -o table || exit 0") | ||
| print("K8S context: ${k8s_context}. Current nodes:") | ||
| sh(script: "kubectl --context ${k8s_context} get nodes") | ||
| sh(script: "kubectl --context ${k8s_context} get nodes || exit 0") |
There was a problem hiding this comment.
It's worth putting a comment why we're silencing the error
aliceinwire
reviewed
Oct 11, 2022
| stage("Init") { | ||
| /* Remove any leftover temporary files */ | ||
| /* Remove any leftover temporary files | ||
| sh(script: "rm -rf *") |
Member
There was a problem hiding this comment.
Just remove this, leaving it make the comment meaningless. as we are not removing any leftover temporary files with the rm -rf anymore
nuclearcat
force-pushed
the
IMPROVE-reliability-patches
branch
2 times, most recently
from
October 11, 2022 12:14
0c9282c to
d38abac
Compare
Several steps to improve job run reliability: * kubectl get nodes are not critical for process and should not cause job termination, ignore exit code. This happen often. * Make .kube configuration file mount as read only, as this volume is shared by multiple processed and getting corrupted. * Update information about rm -rf * Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
IMPROVE-reliability-patches
branch
from
October 11, 2022 12:23
d38abac to
6930287
Compare
Member
Author
|
Latest patch tested on staging jenkins: https://bot.staging.kernelci.org/job/kernel-build/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several steps to improve job run reliability:
1)kubectl get nodes are not critical for process and should not cause job termination, ignore exit code. This happen often.
2)Make .kube configuration file mount as read only, as this volume is shared by multiple processed and getting corrupted.
3)Do not run "rm -rf *" as we are supposed to run in new docker image.
Signed-off-by: Denys Fedoryshchenko denys.f@collabora.com