Skip to content

Implementation of flavor text can add unnecessary information to the logs #73

Open

Description

@Stanek-K

As title says, but I will add some details when and why. Usually everything is fine, but once mod creator starts using token cards for choices, or maybe reprints some cards and will reuse the descriptions of original cards, then the message that a CardString for ID doesn't exist whenever new instance of a card is created, which can quickly get out hand when looking at card library, which constantly makes new instances, and the logs with a lot of some unwanted text.

EDIT: I made a mistake, when it comes to amount of instances of cards that are created normally.

Activity

  1. bkerns724 commented on Jan 2, 2023

    @bkerns724
    Contributor

    Can you tell me which mod and which cards are triggering this behavior? I can not reproduce this currently.

  2. Stanek-K commented on Jan 2, 2023

    @Stanek-K
    Author

    So, I made a mistake with how card library works, so it isn't that bad, but some log messages are still created.
    When it comes to mods that show that, I can only think of Downfall with its Character bosses as they basically use modified reprints to work, so whenever they start a turn their cards log that they don't have a CardString of their own.

    I personally noticed the the log spam after testing if the reprint I added correctly shows in the card library and in Snecko's Unidentified cards, which creates new instances of possible cards constantly, and adds the spam to the log (a point where I got confused how card library works).

  3. bkerns724 commented on Jan 3, 2023

    @bkerns724
    Contributor
    1. How do I reproduce this with mods that are published on the workshop?
    2. Can you attach the logs or a screenshot of them?
  4. changed the title [-]Implementation of flavor text can spam the logs.[/-] [+]Implementation of flavor text can add unnecessary information to the logs[/+] on Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions