Skip to content

Chore mime exclusion list followup - #106

Merged
kjdev merged 2 commits into
masterfrom
chore/mime-exclusion-list-followup
Aug 12, 2026
Merged

Chore mime exclusion list followup#106
kjdev merged 2 commits into
masterfrom
chore/mime-exclusion-list-followup

Conversation

@kjdev

@kjdev kjdev commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation

    • Clarified the wording for the output compression exclusion setting.
  • Tests

    • Added coverage for built-in zstd compression negotiation for audio/mpeg responses.
    • Clarified an existing test description for exact exclusion-list matching.
    • Included the new test in the packaged test suite.

kjdev added 2 commits August 12, 2026 10:28
Also rename ob_exclude_001.phpt to reflect that it verifies the
built-in list, not the exclude_types ini setting.
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c0ccfcd-ea2c-468c-b1f8-54096984075d

📥 Commits

Reviewing files that changed from the base of the PR and between 8b730b2 and 4b430df.

📒 Files selected for processing (4)
  • README.md
  • package.xml
  • tests/ob_exclude_001.phpt
  • tests/ob_exclude_005.phpt

📝 Walkthrough

Walkthrough

The change refines documentation and test naming for built-in MIME-type exclusions. It adds a PHPT test for zstd negotiation with an excluded audio/mpeg response and includes the test in the package contents.

Changes

Compression exclusion coverage

Layer / File(s) Summary
Exclusion behavior documentation and test naming
README.md, tests/ob_exclude_001.phpt
The README describes the built-in non-compressible MIME-type list. The existing test title describes exact matching without an INI setting.
Wildcard exclusion test and package wiring
tests/ob_exclude_005.phpt, package.xml
The new PHPT test checks zstd negotiation and expected uncompressed audio/mpeg output. The package manifest includes the test file.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: pavetheway91

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the MIME exclusion-list follow-up covered by the documentation and test changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/mime-exclusion-list-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kjdev
kjdev merged commit 4b430df into master Aug 12, 2026
157 checks passed
@kjdev
kjdev deleted the chore/mime-exclusion-list-followup branch August 12, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant