Skip to content

Stop relying on internal functions - #11

Merged
fundon merged 3 commits into
koa-modules:masterfrom
LinusU:lu-fix
Oct 3, 2016
Merged

fundon merged 3 commits into
koa-modules:masterfrom
LinusU:lu-fix

Conversation

@LinusU

@LinusU LinusU commented Oct 1, 2016

Copy link
Copy Markdown
Contributor

I removed _makeMiddleware in multer 2.0.0-alpha.1 which broke this module. With this patch we aren't relying on any internal functions, but are instead using only the public api.

@niftylettuce

Copy link
Copy Markdown

Can you please accept this PR? Thanks!

@haoxins

haoxins commented Oct 2, 2016

Copy link
Copy Markdown
Member

cc @fundon

@niftylettuce

Copy link
Copy Markdown

I'd love to have NPM owner and collaborator status if it helps to maintain this package!

@fundon
fundon merged commit f150e31 into koa-modules:master Oct 3, 2016
@fundon

fundon commented Oct 3, 2016

Copy link
Copy Markdown
Member

Sorry to reply you so late

@niftylettuce

Copy link
Copy Markdown

Can you make a tag that uses latest alpha 2.0.0 of multer

On Oct 2, 2016 10:30 PM, "Fangdun Cai" notifications@github.com wrote:

Sorry to reply you so late

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAf7hdyRfB31NQN8MeGmoroplKuqQeE9ks5qwGirgaJpZM4KLwqr
.

@LinusU
LinusU deleted the lu-fix branch October 3, 2016 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants