Keep the failing delegate's stack trace when Invoke rethrows - #55
Merged
Merged
Conversation
Invoke unwrapped the AggregateException from Wait()/.Result and rethrew the inner exception with `throw`, which resets its stack trace to Invoker.Invoke. Cross-thread failures lost every frame of the code that actually failed. Both overloads now use GetAwaiter().GetResult(), which rethrows the original exception with its trace intact. Fixes #54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NHprKRwyYopkJnUyhF3KSr
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54
What changed
When a delegate was marshalled to the owner thread and threw, both synchronous
Invokeoverloads unwrapped theAggregateExceptionand rethrew it withthrow ex.InnerException. That resets the stack trace toInvoker.Invoke. Now both overloads callInvokeAsync(func).GetAwaiter().GetResult(), which rethrows the original exception with its stack trace intact. This also removes thetry/catch.Tests
InvokeActionFromOtherThreadShouldPreserveStackTraceOfFailingCodeandInvokeFunctionFromOtherThreadShouldPreserveStackTraceOfFailingCode. Each callsInvokefrom a worker thread while the owner thread pumpsDoInvokes. The delegate throws from a namedNoInlininghelper, and the test asserts that the helper's name appears in the caught exception'sStackTrace.Invoker.Invoke.🤖 Generated with Claude Code
https://claude.ai/code/session_01NHprKRwyYopkJnUyhF3KSr
Generated by Claude Code