Parse CMaj7, CmMaj7 and C°7 as the sevenths they name - #332
Merged
Merged
Conversation
DetermineSeventh matched "maj", "M7" and 'Δ' but not "Maj", so CMaj7 and CmMaj7 fell through to a dominant seventh. Its diminished-seventh branch checked only "dim", although DetermineQuality also accepts '°', so C°7 became the half-diminished chord. Accept both spellings, and assert the seventh type and pitches directly, since the misparsed chords round-trip. Fixes #281 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VeSBKr7Q99CTQ5BUJMKEct
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281
What
Chord.DetermineSeventh:hasMaj7also matches"Maj". Before,CMaj7parsed asC7andCmMaj7asCm7.'°'as well as"dim", the same testDetermineQualityalready applies to the triad. Before,C°7fell through to a dominant seventh on a diminished triad, which is the half-diminishedCm7b5.Tests
New
Parse_AlternativeSeventhSpellings_GiveTheSeventhTheyNameasserts quality,SeventhTypeandChordTones()directly rather than a round-trip, because the misparsed chords round-trip consistently:CmMaj7CMaj7C°7All three rows fail without the change. With it,
Semantics.Teston net10.0 passes: 1356 passed, 8 skipped, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_01VeSBKr7Q99CTQ5BUJMKEct
Generated by Claude Code