Stop filtering paths on the pull_request trigger - #62
Merged
Merged
Conversation
Sorting's ci.yml predates the template fix in ktsu-dev/.github 48b4ca9 and still filters paths on pull_request. A filtered pull_request trigger reports no check at all, so a docs-only PR (including DESCRIPTION.md and TAGS.md edits) can never satisfy a ruleset waiting on one. Bring the file back to the template in docs/shared-ci.md. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTMFFSY8FY5CpAhf6ikNH1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: Sorting's
ci.yml, written for the canary, filtered paths onpull_requestas well aspush, so a docs-only pull request reported no check at all.After:
ci.ymlmatches the template in shared-ci.md byte for byte, where onlypushfilters paths, the same file the other 49 repositories get in phase 2.How: two lines removed. See the "Why only
pushfilters paths" section of shared-ci.md and ktsu-dev/.github#5.🤖 Generated with Claude Code
https://claude.ai/code/session_01RTMFFSY8FY5CpAhf6ikNH1
Generated by Claude Code