Fix analyzer errors that fail the TUI.Cli release publish - #178
Merged
Merged
Conversation
The RID publish of TUI.Cli failed on 16 analyzer errors in SampleCLI.cs that the regular build does not surface: - IDE0008: explicit types instead of var (lines 22, 25, 28, 41, 49, 64, 76) - IDE0065: usings moved inside the file-scoped namespace (lines 3-7), matching TUI.App - IDE0055: over-indented BorderStyle initializer (line 79) - CA2007: ConfigureAwait(false) on app.RunAsync(), as TUI.App does (33,9) - CA1859: CreateDemoUI returns StackPanel rather than IUIElement (38,28); the now-unused Contracts using is dropped - KTSU0002: AssemblyInfo.cs exposing internals to ktsu.TUI.Test, the same form TUI.App uses Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTMFFSY8FY5CpAhf6ikNH1
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the Release step of the "Analyze & Release" job on main (run 36570689078) failed with
Publish failed for TUI.Cli.csproj (win-x64). The win-x64 publish of TUI.Cli reported 16 analyzer errors inTUI.Cli/SampleCLI.cs. The plain build did not report them, so build and test both passed.After: every error the log lists is fixed, and
SampleCLI.csnow follows the same conventions asTUI.App.#174 only fixed one indentation line. The other 15 errors were still there, which is why the publish kept failing.
How:
varat lines 22, 25, 28, 41, 49, 64 and 76.TUI.App/SampleApp.cs.BorderStyleinitializer on line 79..ConfigureAwait(false)toapp.RunAsync()at (33,9), asTUI.Appalready does everywhere.CreateDemoUIat (38,28) now returnsStackPanelinstead ofIUIElement. That made thektsu.TUI.Core.Contractsusing unused, so it is removed.TUI.Cli/AssemblyInfo.cswith[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("ktsu.TUI.Test")]. This uses the analyzer's suggested form and matchesTUI.App/AssemblyInfo.cs.I did not build this locally because no .NET SDK was available. The fixes follow the reported line and column of each error.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RTMFFSY8FY5CpAhf6ikNH1
Generated by Claude Code