Return a snapshot from GetCommandsToUndo instead of a live query [patch] - #115
Merged
matt-edmondson merged 1 commit intoSep 28, 2026
Merged
Conversation
GetCommandsToUndo returned a deferred Skip/Take over the live command list, so a result enumerated after the stack branched listed the new command in place of the one that was due to be undone. Materialize it, as GetChangeVisualizations already does, and cover both with a test that changes the stack between the call and the enumeration. Fixes #95 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TXZMdofSRgS8oXS9RgTRhM
|
matt-edmondson
deleted the
claude/undoredo-95-snapshot-commands-to-undo
branch
September 28, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95
What was wrong
SaveBoundaryManager.GetCommandsToUndoreturned a deferredSkip/Takeover the live command list. It captured the count when it was called but read the list when the result was enumerated. So a caller that held the result while the stack changed got a mix of old and new state. AfterUndo()followed by a newExecute, the result listed the new command in place of the one it had replaced.GetChangeVisualizations, the other method named in the issue, is already materialized onmain([.. commands.Skip(...)...]), so it needed no code change.Change
SaveBoundaryManager.GetCommandsToUndomaterializes its result ([.. query]). This also coversUndoRedoService.GetCommandsToUndo, which delegates to it.GetCommandsToUndo_EnumeratedAfterBranching_ReflectsStateAtCallfails onmain(Expected:<A,B>. Actual:<A,C>) and passes with the fix.GetChangeVisualizations_EnumeratedAfterExecute_ReflectsStateAtCallguards the existing snapshot behavior against a regression.A note on the issue's third bullet: after a plain
Undo(), a lazy result still reports[A, B], which is also the correct snapshot answer. The two only diverge when the underlying list changes, for example through a branch or a trim, so the test uses a branch.Testing
dotnet test UndoRedo.Test: 102/102 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01TXZMdofSRgS8oXS9RgTRhM
Generated by Claude Code