This repository was archived by the owner on Mar 13, 2022. It is now read-only.
Repository navigation
Add property returncode to WSClient - #160
Merged
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
This will be familiar for Python users as subprocess.Popen has the same attribute. Also, the behavior is such the returncode returns a None value if the process was not run yet. Other than that, when the process exists with a numerical code this will be the value of the return code. If the command executed successfully the return value will be 0.
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=========================================
- Coverage 93.56% 9.97% -83.6%
=========================================
Files 13 13
Lines 1384 1384
=========================================
- Hits 1295 138 -1157
- Misses 89 1246 +1157
Continue to review full report at Codecov.
|
Member
|
/assign |
Member
|
/lgtm Thanks for having it e2e tested in kubernetes-client/python#956! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oz123, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be familiar for Python users as subprocess.Popen has
the same attribute. Also, the behavior is such the returncode returns
a None value if the process was not run yet.
Other than that, when the process exists with a numerical code this will
be the value of the return code. If the command executed successfully
the return value will be 0.