Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

binary websocket streams - #52

Closed
aogier wants to merge 3 commits into
kubernetes-client:masterfrom
aogier:476-binary-streams
Closed

aogier wants to merge 3 commits into
kubernetes-client:masterfrom
aogier:476-binary-streams

Conversation

@aogier

@aogier aogier commented Mar 21, 2018 •

Copy link
Copy Markdown

Hi, this PR gives bytes streams first class citizenship in this codebase, unlocking future features like binary websocket streams as per kubernetes-client/python#476 (for which I'm going to submit code against python client for this).

I hope this could be useful, I've worked unobtrusively so nothing existing should break !

Thank you, regards

@codecov-io

codecov-io commented Mar 21, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          11       11           
  Lines         939      939           
=======================================
  Hits          876      876           
  Misses         63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2010e2d...afe9336. Read the comment docs.

@aogier aogier changed the title binary streams to allow file copy client <-> pods WIP: binary streams to allow file copy client <-> pods Mar 22, 2018
@aogier aogier changed the title WIP: binary streams to allow file copy client <-> pods binary websocket streams Mar 24, 2018
@ltamaster

Copy link
Copy Markdown
Contributor

Hey guys, any news about this PR?

@fejta-bot

Copy link
Copy Markdown

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2019
@zhaofengli

Copy link
Copy Markdown

I have tested the change, and it appears to work well for my use cases. I'd really like this merged back upstream.

@fejta-bot

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2019
@fejta-bot

Copy link
Copy Markdown

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 23, 2019
@hedinasr

hedinasr commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

any news ?

@fejta-bot

Copy link
Copy Markdown

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@fejta-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun

Ark-kun commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

/reopen

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@Ark-kun: You can't reopen an issue/PR unless you authored it or you are a collaborator.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@aogier: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants