Repository navigation
[Examples] Incorrect Module Reference #252
Description
Activity
Yes, all examples need to be updated. We should update example's template (and probably documentation templates) to match our client structure.
Could I be assigned this?
I would go through and fix the module imports for all the examples.
Could you please elaborate on what else needs to be changed about the template for the examples and the documentation? I could try to see what I can do.
Great, Fixing imports (and adding a config.load_kube_config) would be a great start. Just look at one of the examples in examples/ folder and make examples template look close to those. Now to fix templates, you need to copy them somewhere. We are moving toward using kubernetes-client/gen repo for all generations: #284
I have a PR in that repo to move templates from swagger-codegen to gen repo for java client: kubernetes-client/gen#16
you can follow the same pattern, copy templates and start changing them. Make sure you document the branch/sha key from which you copied templates. Don't do everything in one PR, send a PR for moving templates (and all changes necessary for them to work) first to make sure we are on the right path and then start sending PRs to fix example(s) template. Let me know if you had any questions.
Thanks for the pointers. Ok will do. I'll follow the examples for the java client and try to do something similar.
- You should be able to edit one template and generate all examples at once.…On Jul 6, 2017 8:13 PM, "yjww" ***@***.***> wrote: Thanks for the pointers. Ok will do. I'll send the PR example by example as I finish them. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#252 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABic4N_eU67f7jnfmoXYEnsAfI4ypA5Lks5sLaI8gaJpZM4N2yZQ> .
I'm swamped with work unexpectedly and unfortunately. If anyone else wants to take this, go for it. Sorry.
@iamneha: GitHub didn't allow me to assign the following users: iamneha.
Note that only kubernetes-client members and repo collaborators can be assigned.
For more information please see the contributor guideDetails
In response to this:
/assign @iamneha
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with/remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle staleStale issues rot after 30d of inactivity.
Mark the issue as fresh with/remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten@fejta-bot: Closing this issue.
Details
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/closeInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
client-python/examples/create_thirdparty_resource.md
Shows:
from kubernetes.rest import ApiExceptionshould be
from kubernetes.client.rest import ApiExceptionKindly check.