Skip to content

Making the dependency adal optinal #645

Description

@atolj

Hi folks,

I'm currently using the version 'kubernetes==8.0.0a1' and encountered that the ADAL dependency was added. This makes it more difficult to package a container image as it pulls additional dependencies and the image size increases. The following tweet illustrates it perfectly.

https://twitter.com/try_except_/status/1029843228613402627

It would be nice if the dependency is only added under extra_require.

It has also the effect that, when I'm building an alpine image I have to install additional packages like [ build-base, libffi-dev, openssl-dev] or in another case [gcc build-base linux-headers python3-dev ca-certificates python3-dev libffi-dev libressl-dev], which bloats the container further.

I'm currently not sure where the dependency is used.

Activity

  1. roycaihw commented on Oct 12, 2018

    @roycaihw
    Member
  2. added
    kind/designCategorizes issue or PR as related to design.
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 12, 2018
  3. iamneha commented on Oct 24, 2018

    @iamneha
    Contributor

    @roycaihw can you please assign me this issue

  4. yliaog commented on Oct 24, 2018

    @yliaog
    Contributor

    /assign @iamneha

  5. k8s-ci-robot commented on Oct 24, 2018

    @k8s-ci-robot
    Contributor

    @yliaog: GitHub didn't allow me to assign the following users: iamneha.

    Note that only kubernetes-client members and repo collaborators can be assigned.
    For more information please see the contributor guide

    Details

    In response to this:

    /assign @iamneha

    Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

  6. assigned and unassigned on Oct 24, 2018
  7. iamneha commented on Oct 28, 2018

    @iamneha
    Contributor
  8. torgeirl commented on Nov 11, 2018

    @torgeirl

    It has also the effect that, when I'm building an alpine image I have to install additional packages like [ build-base, libffi-dev, openssl-dev] or in another case [gcc build-base linux-headers python3-dev ca-certificates python3-dev libffi-dev libressl-dev], which bloats the container further.

    I were sure I were doing something wrong when making Alpine-based images, but the packages you mentioned makes alpine3.7 images about 300 MB just to make sure the kubernetes package is installed.

  9. fejta-bot commented on Apr 26, 2019

    @fejta-bot

    Issues go stale after 90d of inactivity.
    Mark the issue as fresh with /remove-lifecycle stale.
    Stale issues rot after an additional 30d of inactivity and eventually close.

    If this issue is safe to close now please do so with /close.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /lifecycle stale

  10. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Apr 26, 2019
  11. fejta-bot commented on May 26, 2019

    @fejta-bot

    Stale issues rot after 30d of inactivity.
    Mark the issue as fresh with /remove-lifecycle rotten.
    Rotten issues close after an additional 30d of inactivity.

    If this issue is safe to close now please do so with /close.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /lifecycle rotten

  12. added
    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.
    and removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on May 26, 2019
  13. fejta-bot commented on Jun 25, 2019

    @fejta-bot

    Rotten issues close after 30d of inactivity.
    Reopen the issue with /reopen.
    Mark the issue as fresh with /remove-lifecycle rotten.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /close

  14. k8s-ci-robot commented on Jun 25, 2019

    @k8s-ci-robot
    Contributor

    @fejta-bot: Closing this issue.

    Details

    In response to this:

    Rotten issues close after 30d of inactivity.
    Reopen the issue with /reopen.
    Mark the issue as fresh with /remove-lifecycle rotten.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /close

    Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/designCategorizes issue or PR as related to design.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions