Repository navigation
Setup.py will fail on Windows #676
Description
Activity
/help
/good-first-issue@micw523:
This request has been marked as suitable for new contributors.Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the/remove-good-first-issuecommand.Details
In response to this:
/help
/good-first-issueInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Realized that I should provide a suggested fix with the good first issue label.
I don't think we should revise our script to import from base/config - that could break existing examples and existing codes.
What could be done is someone provides a .bat file under scripts/ to:- make sure python environment exists
- copy base/config to config/
- run python setup.py install.
@jenetiks
-
We should just look for python in the environment - although, we do support Python 2.7. The file setup.py though will be configured to handle this. Personally I don’t expect any developer to clone this repository with Python 2.6 or lower, but that might be up to debate.
-
When we clone submodule with git the folders in the /kubernetes/base is supposed to be symbolically linked in the /kubernetes directory. In Windows this is not done. For a Windows developer, we’ll need to have a script copying all the base/* folders into */.
-
It probably will have to be run in a certain directory, likely the root of the repo or scripts. It needs to be documented well where it is supposed to be run though.
-
I’ll prefer to be a bat script. Although I don’t develop this repo in Windows, I do use Anaconda and python environments variables are only available under the Anaconda Prompt (cmd).
Correct me if you have other thoughts. /cc @roycaihw
-
/priority backlog
/priority backlog
Hello @micw523 Gave a PR that solves the issue.
Added shell script to check python environment, prints the python version, copy files from /kubernetes/base to /kubernetes/ and finally runs python setup.py install.
- added a commit that references this issue
on Feb 20, 2019
This issue references #479, as it is a restriction on the current repo.
This repo uses symbolic link when managing the submodules, so that the folders in /kubernetes/base can be referenced in /kubernetes.
Windows does not have symbolic link, so Windows developers will have to manually copy the folders over after doing a --recursive clone.
This should be a simple enough fix in case someone wants to take a crack at it.