Skip to content

rest request should squash URL #688

Closed

Description

@glbyers

In later versions of k8s, a request to //version is invalid, whilst a request to /version responds as expected. This appears to be an upstream bug, but it can be handled gracefully enough by simply "squashing" the URL path. ie.

scheme, netloc, path, params, query, fragment = urlparse(url)
urlunparse((scheme, netloc, re.sub(r'path, /+', '/', path), params, query, fragment))

Can it be handled gracefully here?

Activity

  1. roycaihw commented on Nov 12, 2018

    @roycaihw
    Member

    @glbyers Could you take a look at kubernetes-client/python-base#45 to see if it solves your problem?

    Besides the host url containing trailing slash in kubeconfig file, do you have any other specific cases that cause invalid url in this client package?

  2. glbyers commented on Nov 13, 2018

    @glbyers
    Author

    Thanks @roycaihw, I will test this tomorrow. It certainly looks like it should work around the issue (FWIW, I'd already removed the trailing / from my kubeconfig to get around this initially.

  3. fejta-bot commented on Apr 26, 2019

    @fejta-bot

    Issues go stale after 90d of inactivity.
    Mark the issue as fresh with /remove-lifecycle stale.
    Stale issues rot after an additional 30d of inactivity and eventually close.

    If this issue is safe to close now please do so with /close.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /lifecycle stale

  4. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Apr 26, 2019
  5. fejta-bot commented on May 26, 2019

    @fejta-bot

    Stale issues rot after 30d of inactivity.
    Mark the issue as fresh with /remove-lifecycle rotten.
    Rotten issues close after an additional 30d of inactivity.

    If this issue is safe to close now please do so with /close.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /lifecycle rotten

  6. added
    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.
    and removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on May 26, 2019
  7. fejta-bot commented on Jun 26, 2019

    @fejta-bot

    Rotten issues close after 30d of inactivity.
    Reopen the issue with /reopen.
    Mark the issue as fresh with /remove-lifecycle rotten.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /close

  8. k8s-ci-robot commented on Jun 26, 2019

    @k8s-ci-robot
    Contributor

    @fejta-bot: Closing this issue.

    Details

    In response to this:

    Rotten issues close after 30d of inactivity.
    Reopen the issue with /reopen.
    Mark the issue as fresh with /remove-lifecycle rotten.

    Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
    /close

    Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions