Repository navigation
Add e2e test for strategic merge patch #951
Description
Add a test sending (e.g. config map) patches through the same API using:
- JSON patch
- Strategic merge patch
make sure the API client is able to set the content type properly according to the request body, and the patches are applied successfully.
ref: #931 (comment)
Metadata
Metadata
Assignees
Labels
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Categorizes issue or PR as related to a new feature.Indicates that an issue or PR should not be auto-closed due to staleness.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Activity
palnabarun commentedon Oct 6, 2019
I want to give a shot at this. :)
/assign
fejta-bot commentedon Jan 4, 2020
Issues go stale after 90d of inactivity.
Mark the issue as fresh with
/remove-lifecycle stale.Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
palnabarun commentedon Jan 5, 2020
/remove-lifecycle stale
roycaihw commentedon Mar 12, 2020
Examples of using these patches:
strategic merge patch: #641 (comment)
json patch: #641 (comment)
We can have one test sending multiple kinds of patch and make sure nothing fails, or two tests doing the same thing but using different kinds of patch.
fejta-bot commentedon Jun 10, 2020
Issues go stale after 90d of inactivity.
Mark the issue as fresh with
/remove-lifecycle stale.Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot commentedon Jul 10, 2020
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with
/remove-lifecycle rotten.Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
4 remaining items
fejta-bot commentedon Mar 6, 2021
Rotten issues close after 30d of inactivity.
Reopen the issue with
/reopen.Mark the issue as fresh with
/remove-lifecycle rotten.Send feedback to sig-contributor-experience at kubernetes/community.
/close
k8s-ci-robot commentedon Mar 6, 2021
@fejta-bot: Closing this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
roycaihw commentedon Mar 9, 2021
/reopen
/remove-lifecycle rotten
/lifecycle frozen
/priority important-soon
k8s-ci-robot commentedon Mar 9, 2021
@roycaihw: Reopened this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
pmareke commentedon Sep 26, 2022
Hi everyone!
After reading the issue, the examples and the e2e tests I would like to give it a try.
As far as I understand I have to add a couple of e2e tests patching a config map with the 2 strategies right?
Thanks for your time!
/assign
pmareke commentedon Sep 27, 2022
Sorry for the multiple pull requests, I made a typo naming the branch.