Skip to content

Add example code for enabling debugging - #1083

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
roycaihw:enable-debug
Feb 19, 2020
Merged

k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
roycaihw:enable-debug

Conversation

@roycaihw

Copy link
Copy Markdown
Member

ref #1039 (comment)

setting debug to true allows the client to log HTTP request sent to the server.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2020
@k8s-ci-robot
k8s-ci-robot requested a review from yliaog February 18, 2020 21:08
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2020
@roycaihw

Copy link
Copy Markdown
Member Author

/cc @micw523 @scottilee

@k8s-ci-robot
k8s-ci-robot requested a review from micw523 February 18, 2020 21:08
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @micw523 @scottilee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@micw523

micw523 commented Feb 19, 2020

Copy link
Copy Markdown
Contributor

/lgtm
On the other hand, we should probably think about a master document on explaining what the examples do. People won’t necessarily expect this example to teach them how to do debug logging by looking at the file name.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2020
@k8s-ci-robot
k8s-ci-robot merged commit f493272 into kubernetes-client:master Feb 19, 2020
@roycaihw

Copy link
Copy Markdown
Member Author

I agree. We have examples that cover similar areas. It would be better to de-dup the examples and document their focuses in a README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants