Repository navigation
add basic watch configmap e2e test - #1087
Merged
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
roycaihw
requested review from
micw523 and
palnabarun
and removed request for
yliaog
February 22, 2020 01:42
roycaihw
force-pushed
the
watch-e2e
branch
2 times, most recently
from
February 24, 2020 06:51
3b1f804 to
6b7b61e
Compare
micw523
reviewed
Mar 2, 2020
micw523
left a comment
micw523
left a comment
Contributor
There was a problem hiding this comment.
This generally lgtm. I have only one comment.
| name=name_b, namespace='default', body=configmap_b) | ||
|
|
||
| # delete all configmaps | ||
| resp = api.delete_collection_namespaced_config_map( |
Contributor
There was a problem hiding this comment.
Looks like the resp on line 56, 66, 71, 75 are unused. Is it possible to not assign the return value to a variable?
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in future we can add tests for