Skip to content

Move inactive members to emeritus - #915

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
scottilee:owners
Aug 5, 2019
Merged

k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
scottilee:owners

Conversation

@scottilee

Copy link
Copy Markdown
Contributor

Updating the OWNERS file in order for pull requests to get assigned to the correct people.

/assign @roycaihw

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2019
@roycaihw

roycaihw commented Aug 3, 2019

Copy link
Copy Markdown
Member

The background is for the bot to correctly request review in PRs like #911. The Emeritus key is documented here

/lgtm
/approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2019
@micw523

micw523 commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

@roycaihw You need to /approve it again

@roycaihw

roycaihw commented Aug 5, 2019

Copy link
Copy Markdown
Member

oops. Thanks @micw523

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, scottilee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@k8s-ci-robot
k8s-ci-robot merged commit 1d51d5a into kubernetes-client:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants