Skip to content

zap-time-encoding help text still says the default is 'epoch' #3634

Open

Description

@Manishram-ai

Since #2029, the zap logger defaults to RFC3339 timestamps (o.TimeEncoder = zapcore.RFC3339TimeEncoder in pkg/log/zap/zap.go). The --zap-time-encoding flag help and the BindFlags doc comment still say "Defaults to 'epoch'", though.

I ran into this with an operator built on v0.24.1. Its --help says "Defaults to 'epoch'.", but with the flag unset the logs come out as 2026-10-31T17:23:56-07:00.

Both strings just need to say 'rfc3339'. I'm happy to send a PR for it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions