Repository navigation
✨ Priorityqueue: Enable per default - #3332
Merged
k8s-ci-robot merged 1 commit intoOct 6, 2025
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Member
Author
|
/assign @alvaroaleman /hold |
k8s-ci-robot
added
do-not-merge/hold
sbueringer
commented
Oct 3, 2025
sbueringer
changed the title
alvaroaleman
reviewed
Oct 4, 2025
sbueringer
force-pushed
the
pr-enable-pq-per-default
branch
3 times, most recently
from
October 5, 2025 09:41
10a58d4 to
0964f37
Compare
sbueringer
changed the title
sbueringer
force-pushed
the
pr-enable-pq-per-default
branch
from
October 5, 2025 09:51
0964f37 to
7ef9086
Compare
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-enable-pq-per-default
branch
from
October 6, 2025 08:25
7ef9086 to
d2c0c8b
Compare
k8s-ci-robot
added
size/S
Member
Author
|
@alvaroaleman Rebased, PTAL |
k8s-ci-robot
added
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: c2cc67ee1bf9026ad10733fa968670345f49ffa4 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 of 3 tasks
felix-kaestner
added a commit
to ironcore-dev/network-operator
that referenced
this pull request
Mar 27, 2026
Upgrades controller-runtime from v0.22.4 to v0.23.3. The k8s.io/* packages were already at v0.35.0 and required no changes. The priority queue is now enabled by default (kubernetes-sigs/controller-runtime#3332), so the explicit UsePriorityQueue: new(true) in cmd/main.go is dropped. The webhook builder API changed to a generic form (kubernetes-sigs/controller-runtime#3360). NewWebhookManagedBy(mgr).For(&T{}) is replaced by NewWebhookManagedBy(mgr, &T{}). Validators are migrated from the deprecated CustomValidator interface with runtime.Object signatures to the typed Validator[T] interface with concrete types, removing the type assertion boilerplate. Test cases for wrong-object-type errors are removed as they are no longer expressible at runtime. The events API changed from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (kubernetes-sigs/controller-runtime#3262). GetEventRecorderFor is replaced by GetEventRecorder. All controllers and the provisioning server are updated accordingly, and call sites are updated to the new Eventf signature which adds related object and action fields. Tests use the new events.NewFakeRecorder.
felix-kaestner
added a commit
to ironcore-dev/network-operator
that referenced
this pull request
Mar 27, 2026
The priority queue is now enabled by default (kubernetes-sigs/controller-runtime#3332), so the explicit UsePriorityQueue: new(true) in cmd/main.go is dropped. The webhook builder API changed to a generic form (kubernetes-sigs/controller-runtime#3360). NewWebhookManagedBy(mgr).For(&T{}) is replaced by NewWebhookManagedBy(mgr, &T{}). Validators are migrated from the deprecated CustomValidator interface with runtime.Object signatures to the typed Validator[T] interface with concrete types, removing the type assertion boilerplate. Test cases for wrong-object-type errors are removed as they are no longer expressible at runtime. The events API changed from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (kubernetes-sigs/controller-runtime#3262). GetEventRecorderFor is replaced by GetEventRecorder. All controllers and the provisioning server are updated accordingly, and call sites are updated to the new Eventf signature which adds related object and action fields. Tests use the new events.NewFakeRecorder.
felix-kaestner
added a commit
to ironcore-dev/network-operator
that referenced
this pull request
Mar 27, 2026
The priority queue is now enabled by default (kubernetes-sigs/controller-runtime#3332), so the explicit UsePriorityQueue: new(true) in cmd/main.go is dropped. The webhook builder API changed to a generic form (kubernetes-sigs/controller-runtime#3360). NewWebhookManagedBy(mgr).For(&T{}) is replaced by NewWebhookManagedBy(mgr, &T{}). Validators are migrated from the deprecated CustomValidator interface with runtime.Object signatures to the typed Validator[T] interface with concrete types, removing the type assertion boilerplate. Test cases for wrong-object-type errors are removed as they are no longer expressible at runtime. The events API changed from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (kubernetes-sigs/controller-runtime#3262). GetEventRecorderFor is replaced by GetEventRecorder. All controllers and the provisioning server are updated accordingly, and call sites are updated to the new Eventf signature which adds related object and action fields. Tests use the new events.NewFakeRecorder.
felix-kaestner
added a commit
to ironcore-dev/network-operator
that referenced
this pull request
Mar 30, 2026
The priority queue is now enabled by default (kubernetes-sigs/controller-runtime#3332), so the explicit UsePriorityQueue: new(true) in cmd/main.go is dropped. The webhook builder API changed to a generic form (kubernetes-sigs/controller-runtime#3360). NewWebhookManagedBy(mgr).For(&T{}) is replaced by NewWebhookManagedBy(mgr, &T{}). Validators are migrated from the deprecated CustomValidator interface with runtime.Object signatures to the typed Validator[T] interface with concrete types, removing the type assertion boilerplate. Test cases for wrong-object-type errors are removed as they are no longer expressible at runtime. The events API changed from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (kubernetes-sigs/controller-runtime#3262). GetEventRecorderFor is replaced by GetEventRecorder. All controllers and the provisioning server are updated accordingly, and call sites are updated to the new Eventf signature which adds related object and action fields. Tests use the new events.NewFakeRecorder.
felix-kaestner
added a commit
to ironcore-dev/network-operator
that referenced
this pull request
Mar 30, 2026
The priority queue is now enabled by default (kubernetes-sigs/controller-runtime#3332), so the explicit UsePriorityQueue: new(true) in cmd/main.go is dropped. The webhook builder API changed to a generic form (kubernetes-sigs/controller-runtime#3360). NewWebhookManagedBy(mgr).For(&T{}) is replaced by NewWebhookManagedBy(mgr, &T{}). Validators are migrated from the deprecated CustomValidator interface with runtime.Object signatures to the typed Validator[T] interface with concrete types, removing the type assertion boilerplate. Test cases for wrong-object-type errors are removed as they are no longer expressible at runtime. The events API changed from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (kubernetes-sigs/controller-runtime#3262). GetEventRecorderFor is replaced by GetEventRecorder. All controllers and the provisioning server are updated accordingly, and call sites are updated to the new Eventf signature which adds related object and action fields. Tests use the new events.NewFakeRecorder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
Part of #2374