Skip to content

🐛 controller/metrics: drop MetricsAll from the default GoCollector #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 1 commit into from
Closed

🐛 controller/metrics: drop MetricsAll from the default GoCollector #3507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/internal/controller/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,17 @@ func init() {
ReconcileTimeouts,
// expose process metrics like CPU, Memory, file descriptor usage etc.
collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),
// expose all Go runtime metrics like GC stats, memory stats etc.
collectors.NewGoCollector(collectors.WithGoCollectorRuntimeMetrics(collectors.MetricsAll)),
// expose the default Go runtime metrics (GC stats, memory
// stats, etc.). The collectors.MetricsAll variant this
// previously used balloons cardinality roughly 5x: a v0.19
// -> v0.23 bump took an unchanged daemonset controller
// from ~31 go_* series per pod to ~142, enough to blow past
// per-project metric quotas. The opt-out was reverted on the
// 0.19 / 0.20 release branches via #3147 / #3148 but the
// revert was never forward-ported to 0.21+. Restore the
// conservative default; operators who want the extra
// metrics can register their own GoCollector with MetricsAll
// on the Registry themselves (#3505).
collectors.NewGoCollector(),
)
}
Loading