Skip to content

🌱ci: Update golangci-lint to v2.1.6 and adjust configuration - #1182

Closed
dongjiang1989 wants to merge 5 commits into
kubernetes-sigs:mainfrom
dongjiang1989:update-golangci-tools-v2
Closed

🌱ci: Update golangci-lint to v2.1.6 and adjust configuration#1182
dongjiang1989 wants to merge 5 commits into
kubernetes-sigs:mainfrom
dongjiang1989:update-golangci-tools-v2

Conversation

@dongjiang1989

@dongjiang1989 dongjiang1989 commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This updates golangci-lint to v2.1.6 with the associated configuration in workflows and Makefile

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2025
@k8s-ci-robot

k8s-ci-robot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2025
JoelSpeed
JoelSpeed reviewed Apr 3, 2025
View reviewed changes

@JoelSpeed JoelSpeed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure to keep this in parity with kubernetes-sigs/controller-runtime#3187

Comment thread .golangci.yml Resolved
@JoelSpeed

JoelSpeed commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2025
@k8s-ci-robot

k8s-ci-robot commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 9ea1bc73ecca0815ebf9dcaad576b37fde54ba1d

camilamacedo86
camilamacedo86 reviewed Apr 11, 2025
View reviewed changes

@camilamacedo86 camilamacedo86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 11, 2025
@k8s-ci-robot
k8s-ci-robot requested a review from JoelSpeed April 14, 2025 09:06
@dongjiang1989
update golangci lint v2
577ba30 
Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989
dongjiang1989 force-pushed the update-golangci-tools-v2 branch from 0a9cbe4 to 577ba30 Compare April 14, 2025 09:11
@chrischdi chrischdi mentioned this pull request Apr 14, 2025
Closed
@dongjiang1989 dongjiang1989 mentioned this pull request Apr 21, 2025
Closed
@JoelSpeed

JoelSpeed commented May 2, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2025
@k8s-ci-robot

k8s-ci-robot commented May 2, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 3fd9cf017b726416f1b10bb95d7f90a4ada218cb

@sbueringer

sbueringer commented May 7, 2025

Copy link
Copy Markdown
Member

/assign

I'll try to get around to it soon

@dongjiang1989

dongjiang1989 commented May 8, 2025

Copy link
Copy Markdown
Member Author

/assign

I'll try to get around to it soon

Thanks @sbueringer

@sbueringer sbueringer mentioned this pull request May 8, 2025
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@k8s-ci-robot
k8s-ci-robot requested a review from sbueringer May 9, 2025 09:42
@k8s-ci-robot

k8s-ci-robot commented May 9, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989
Once this PR has been reviewed and has the lgtm label, please ask for approval from sbueringer. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2025
@JoelSpeed

JoelSpeed commented May 9, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@k8s-ci-robot

k8s-ci-robot commented May 9, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: e9f4c751350b05f7acedd4dc586d8a23b2c29571

@sbueringer

sbueringer commented May 13, 2025

Copy link
Copy Markdown
Member

I reviewed kubernetes-sigs/controller-runtime#3187 first. Let's get the one in CR merged and then we can follow-up here

@sbueringer

sbueringer commented May 14, 2025

Copy link
Copy Markdown
Member

@dongjiang1989 Just approved kubernetes-sigs/controller-runtime#3187

Can you please:

  • also bump to v2.1.6 / action 8.0.0
  • check if any of the findings on the CR PR are also applicable here

I'll review afterwards

@dongjiang1989
update by codereview
cf79ea4 
Signed-off-by: dongjiang <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2025
@k8s-ci-robot

k8s-ci-robot commented May 15, 2025

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@dongjiang1989
Revert "Merge branch 'main' into update-golangci-tools-v2"
e215bbd 
This reverts commit c654caa, reversing
changes made to 577ba30.
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@dongjiang1989 dongjiang1989 changed the title 🌱ci: Update golangci-lint to v2.0.2 and adjust configuration 🌱ci: Update golangci-lint to v2.1.6 and adjust configuration May 15, 2025
@dongjiang1989

dongjiang1989 commented May 15, 2025

Copy link
Copy Markdown
Member Author

@dongjiang1989 Just approved kubernetes-sigs/controller-runtime#3187

Can you please:

  • also bump to v2.1.6 / action 8.0.0
  • check if any of the findings on the CR PR are also applicable here

I'll review afterwards

Thanks @sbueringer
Please review #1206

@dongjiang1989 dongjiang1989 mentioned this pull request May 15, 2025
Merged
@dongjiang1989

dongjiang1989 commented May 15, 2025

Copy link
Copy Markdown
Member Author

Move to #1206 , Close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi
@joelanford joelanford Awaiting requested review from joelanford
@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed
@sbueringer sbueringer Awaiting requested review from sbueringer
1 more reviewer
@camilamacedo86 camilamacedo86 camilamacedo86 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sbueringer sbueringer

@JoelSpeed JoelSpeed

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dongjiang1989 @k8s-ci-robot @JoelSpeed @sbueringer @camilamacedo86