[arvindbr8]

Description

This PR refines the tools/update-proto.sh script to ensure reproducible protobuf code generation across different developer environments and CI.

Currently, the script only installs protoc if it is completely missing from the host. If a developer has an older version of protoc installed system-wide (e.g., 3.21.12), the script will use it, producing different generated code than the CI environment (which uses 34.1).

Key Changes

• Version Check: Updated the script to not only check if protoc is installed, but also verify that its version matches the requested PROTOC_VERSION (34.1).
• Forced Local Installation on Mismatch: If the version mismatches or is not found, it downloads the correct release asset from GitHub and installs it locally in _tmp/bin, overriding the system version for the duration of the script.
• Generator Updates: Removed the guard checks for protoc-gen-go and protoc-gen-go-grpc to ensure the latest versions of these generators are fetched via go install every time.

Verification Results

1. Verified locally on a machine with an older protoc version: The script successfully detected the mismatch, downloaded version 34.1, and placed it in _tmp/bin.
2. Verified that the generated .pb.go files now perfectly match what the CI expects, resolving verify-up-to-date failures.

/hold for reviews from @YifeiZhuang
/label tide/merge-method-squash

[k8s-ci-robot]

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Hi @arvindbr8. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[YifeiZhuang]

It looks protoc is quite stable, my local old ptotoc version generates the same code as protoc 34.1.
The prow CI environment always install protoc so we will detect immediately if there are ungenerated code.

I think one thing we need to automate/track is to update this protoc version.

[YifeiZhuang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arvindbr8, YifeiZhuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [YifeiZhuang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[YifeiZhuang]

/ok-to-test

[aojea]

/hold for reviews from @YifeiZhuang

I assume this is an oversight #1069 (comment) since it was already approved

/hold cancel